260311 fix ca24 cafe effect#137
Open
Babel-TTT wants to merge 2 commits into
Open
Conversation
wensimehrp
reviewed
Mar 24, 2026
| 1037: switch_cr200jc_cab_capacity_wy; | ||
| 1039: switch_cr200jc_cab_capacity_wg; | ||
| 1051: return 0; | ||
| 1536: return 0; |
Member
There was a problem hiding this comment.
说实话感觉这里有点儿奇怪……type id明明可以用宏全部定义的，或者用nml内置常量功能
jfkuayue
requested changes
May 1, 2026
Member
jfkuayue
left a comment
jfkuayue
left a comment
There was a problem hiding this comment.
request changes as in comments
| graphics { | ||
| // Menu | ||
| additional_text: string(STR_DESC_5, string(STR_FULL_NAME_CA24DDR), string(STR_DDR_IMPORT), string(STR_SELF_AIR_CONDITIONER), string(STR_CAFE_EFFECT), string(STR_LV_AVAILABLE_S ,string(STR_LIVERY_AVAILABLE), string(STR_IMPORT_1ST), string(STR_IMPORT_1ST_INT)), string(STR_COMFORT_MEDIUM, 240)); | ||
| additional_text: string(STR_DESC_5, string(STR_FULL_NAME_CA24DDR), string(STR_DDR_IMPORT), string(STR_CAFE_EFFECT), string(STR_SELF_AIR_CONDITIONER), string(STR_CAFE_EFFECT), string(STR_LV_AVAILABLE_S ,string(STR_LIVERY_AVAILABLE), string(STR_IMPORT_1ST), string(STR_IMPORT_1ST_INT)), string(STR_COMFORT_MEDIUM, 240)); |
Member
There was a problem hiding this comment.
Why is there a double STR_CAFE_EFFECT?
Member
There was a problem hiding this comment.
And also should be STR_DESC_6 to contain that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.