Codechange: Use f-strings instead of concatenation in exceptions.#402
Open
PeterN wants to merge 1 commit intoOpenTTD:masterfrom
Open
Codechange: Use f-strings instead of concatenation in exceptions.#402PeterN wants to merge 1 commit intoOpenTTD:masterfrom
PeterN wants to merge 1 commit intoOpenTTD:masterfrom
Conversation
Contributor
|
Oh the weird and annoying limitations of f-strings before 3.12. |
Member
Author
|
Hah! So let's not use f-strings yet. Sorry @LordAro, |
Contributor
|
We could also drop support for older python. |
Member
|
Get rid of the explicit str() and convert |
LordAro
force-pushed
the
f-string-errors
branch
from
051176a to
f07b8d8
Compare
LordAro
force-pushed
the
f-string-errors
branch
from
f07b8d8 to
9389496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So let's, generally speaking, do that?