Relative units for sizes, margins and paddings of the page header#376
Open
auge8472 wants to merge 8 commits intoOpenTTD:mainfrom
Open
Relative units for sizes, margins and paddings of the page header#376auge8472 wants to merge 8 commits intoOpenTTD:mainfrom
auge8472 wants to merge 8 commits intoOpenTTD:mainfrom
Conversation
…dren Signed-off-by: Heiko August <post@auge8472.de>
… colour gradients Use the property background for both cases instead of background-color and background-image. Signed-off-by: Heiko August <post@auge8472.de>
Signed-off-by: Heiko August <post@auge8472.de>
…t em Signed-off-by: Heiko August <post@auge8472.de>
…ng for the contained list Signed-off-by: Heiko August <post@auge8472.de>
…n the links Signed-off-by: Heiko August <post@auge8472.de>
Signed-off-by: Heiko August <post@auge8472.de>
Signed-off-by: Heiko August <post@auge8472.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the pull request for changing the font sizes, positions, margins and paddings to relative units as previously proposed for the page footer in #374.
The font size is set to 86% of the browsers default font size (
0.86em). All margins and paddings are now set with the unitemand are therefore linked to the font size of the specific element. Furthermore the padding of the header itself is unified to a single value which is the same on all four sides of the element.As last change I replaced the OpenTTD-icon-GIF with the SVG from the OpenTTD repository. To prevent the semitransparent lowest layer to make the background element under the icon visible I added a background layer in a very bright grey (
#eeeeee).