Skip to content

fix: skip result overwrite in streaming mode, add running indicator o… #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OpenTester007 merged 1 commit into from
Jun 30, 2026
Merged

fix: skip result overwrite in streaming mode, add running indicator o… #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ document.addEventListener('DOMContentLoaded', () => {

isMainOperationInProgress = true;
currentMainOperationAbortController = new AbortController();
const translateTabBtn = document.getElementById('translate-tab');
if (translateTabBtn) translateTabBtn.classList.add('is-running');
if (clearOrStopBtn) {
clearOrStopBtn.textContent = '停止';
clearOrStopBtn.classList.add('stop-btn');
Expand All @@ -174,12 +176,14 @@ document.addEventListener('DOMContentLoaded', () => {
translateOutput.value = '';

try {
const isStreaming = streamTranslateCheckbox && streamTranslateCheckbox.checked;
const result = await callAPI(inputVal, type, [], currentMainOperationAbortController.signal);
if (typeof result === 'string') {
// Bug 3 fix: skip overwrite if streaming already filled the output incrementally
if (typeof result === 'string' && !isStreaming) {
translateOutput.value = result;
if (document.getElementById('history') && !document.getElementById('history').hidden) {
await initializeHistory();
}
}
if (document.getElementById('history') && !document.getElementById('history').hidden) {
await initializeHistory();
}
} catch (error) {
if (error.name === 'AbortError') {
Expand All @@ -190,6 +194,7 @@ document.addEventListener('DOMContentLoaded', () => {
}
} finally {
isMainOperationInProgress = false;
if (translateTabBtn) translateTabBtn.classList.remove('is-running');
if (clearOrStopBtn) {
clearOrStopBtn.textContent = '清空';
clearOrStopBtn.classList.remove('stop-btn');
Expand Down Expand Up @@ -444,8 +449,6 @@ document.addEventListener('DOMContentLoaded', () => {
const currentActiveTabId = currentActiveTabButton ? currentActiveTabButton.dataset.tab : null;
const targetTabId = button.dataset.tab;



document.querySelectorAll('.tab-nav__btn').forEach(btn => {
btn.classList.remove('is-active');
btn.setAttribute('aria-selected', 'false');
Expand Down
22 changes: 22 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,28 @@ body {
box-shadow: var(--shadow-md);
}

/* Animated dot shown on the translate tab button while a background task is running */
.tab-nav__btn.is-running::after {
content: '';
display: inline-block;
width: 6px;
height: 6px;
margin-left: 5px;
border-radius: 50%;
background-color: var(--primary-color);
vertical-align: middle;
animation: pulse-dot 1.2s ease-in-out infinite;
}

.tab-nav__btn.is-active.is-running::after {
background-color: var(--surface-color);
}

@keyframes pulse-dot {
0%, 100% { opacity: 1; transform: scale(1); }
50% { opacity: 0.4; transform: scale(0.7); }
}

/* Tab Panels */
.tab-container {
display: flex;
Expand Down
Loading