Add "PKCS#11 URIs compliant with RFC7512" patch#110
Conversation
added patch from OpenSC/pkcs11-helper#4
|
In yesterday's community meeting @dazo and @cron2 gave a feature-ACK for bundling this patch in new 2.4 Windows installers. @chipitsine : does the patch actually apply? I'm asking because the old lzo-2.05 patch had this header: This PR's patch has this header: I think you would need to have this instead: This way openvpn-build would know that it needs to patch pkcs11-helper. |
|
@mattock , I tested, patch does apply. can you please test yourself as well ? just 'git clone -b RFC7512 https://github.com/chipitsine/openvpn-build' and build it ? |
|
@mattock , how was your test ? I think, as long as we apply patch with "-p1", the header does not matter |
|
@chipitsine : haven't had the time to test yet. That said, I will need to rebuild at least 2.3-based Windows installers late next week. That will be a good time to verify this patch also. |
|
@mattock , did you test it? |
|
As agreed in today's IRC meeting I'll merge this now. |
added patch from OpenSC/pkcs11-helper#4