build(deps): take vta-sdk 0.39, so OpenVTC can follow without a duplicate - #55
Merged
Merged
Conversation
…cate
VTI published `vta-sdk 0.39.0`, a major: `verify_trust_task_proof_with` became
generic over the payload, and `KeyType` gained ML-DSA variants.
While this line declared `^0.38`, **OpenVTC could not move.** It consumes
`did-git-sign`, so raising its own pin resolved *two* sdk copies — 0.38.2 for
this crate and 0.39.0 for itself. That is the state OpenVTC's manifest records
having escaped "for the first time since 0.35", after the obligation here had
blocked six consecutive minors (0.23, 0.25, 0.27, 0.31, 0.32, 0.34).
This line's own note named the job: *"It is one row here today; it will be two
in OpenVTC until that move happens, and that is the thing to fix next."* This is
that move.
## It compiled unchanged
No source edit was needed. Neither breaking change in 0.39 touches this
workspace: nothing here calls `verify_trust_task_proof_with`, and nothing
matches on `KeyType` (OpenVTC did, and needed a catch-all arm). The pin was the
whole of it.
Verified rather than assumed: `cargo tree -i vta-sdk` resolves a **single**
0.39.0 node, and `cargo tree -d` shows no sdk row at all. `fmt`, `clippy
--workspace --all-targets -D warnings` and the full test suite are green.
## Why a duplicate is not merely untidy
While the last one lasted it cost a `cargo tree -d` row rather than a build
failure, for a narrow reason: OpenVTC uses `did_git_sign::{config, init}` only,
so no sdk type crosses that boundary. One new import turns it into a type error,
because `vti-common` re-exports `vta_sdk::acl` types that cannot unify across
copies. Keeping this line current is what keeps that trap closed.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTI published
vta-sdk 0.39.0, a major:verify_trust_task_proof_withbecamegeneric over the payload, and
KeyTypegained ML-DSA variants.While this line declared
^0.38, OpenVTC could not move. It consumesdid-git-sign, so raising its own pin resolved two sdk copies — 0.38.2 forthis crate and 0.39.0 for itself. That is the state OpenVTC's manifest records
having escaped "for the first time since 0.35", after the obligation here had
blocked six consecutive minors (0.23, 0.25, 0.27, 0.31, 0.32, 0.34).
This line's own note named the job: "It is one row here today; it will be two
in OpenVTC until that move happens, and that is the thing to fix next." This is
that move.
It compiled unchanged
No source edit was needed. Neither breaking change in 0.39 touches this
workspace: nothing here calls
verify_trust_task_proof_with, and nothingmatches on
KeyType(OpenVTC did, and needed a catch-all arm). The pin was thewhole of it.
Verified rather than assumed:
cargo tree -i vta-sdkresolves a single0.39.0 node, and
cargo tree -dshows no sdk row at all.fmt,clippy --workspace --all-targets -D warningsand the full test suite are green.Why a duplicate is not merely untidy
While the last one lasted it cost a
cargo tree -drow rather than a buildfailure, for a narrow reason: OpenVTC uses
did_git_sign::{config, init}only,so no sdk type crosses that boundary. One new import turns it into a type error,
because
vti-commonre-exportsvta_sdk::acltypes that cannot unify acrosscopies. Keeping this line current is what keeps that trap closed.