fix(tsp-js): resolveAccept, so an accept for an invite never sent is not adopted - #250
Merged
stormer78 merged 1 commit intoSep 16, 2026
Conversation
…not adopted Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets
feat/tsp-rev2-rev3-dual-handler, like #249.tsp-jsships its relationship rules as pure functions, but none of them compared an accept's Digest with the invite we sent.transition(pending, "receiveAccept")only sees the state, so a client that relied on the library's rules would adopt an accept for an invite it never sent (§7.2.2).resolveAccept(state, answeredDigest, ourInviteDigest)returnsadoptorignore, mirroringresolveCancel. It is exported, and the README and CHANGELOG are updated.ensureRelationshipalready made this check inline, so the wallet was not affected. It now callsresolveAccept, and a new test covers an accept that names the wrong digest.This was found by the cross-implementation TSP Rev 3 conformance suite, where it failed in 5 cases. With this branch, the suite's relationship cases pass across all 5 implementations (250/250).
Tests:
npm test: 111 pass.tests/tsp.*.mjs: 33 pass.