Skip to content

CI: Add JRuby 10 testing #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bastelfreak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CI: Add JRuby 10 testing #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5067b4
CI: Add JRuby 10 testing
bastelfreak Aug 24, 2025
1071d8c
CI: Install JRuby 10 w/ Java 21 & JRuby 9 w/ Java 17
bastelfreak Apr 17, 2026
cf3b195
CI: Ensure dummy fact is not empty
bastelfreak Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
- {os: ubuntu-24.04, ruby: '4.0'}
- {os: ubuntu-24.04, ruby: 'jruby-9.4.8.0'}
- {os: ubuntu-24.04, ruby: 'jruby-9.4.14.0'}
- {os: ubuntu-24.04, ruby: 'jruby-10.0.5.0'}
- {os: windows-2025, ruby: '3.2'}
- {os: windows-2025, ruby: '3.3'}
- {os: windows-2025, ruby: '3.4'}
Expand All @@ -57,7 +58,20 @@ jobs:
steps:
- name: Checkout current PR
uses: actions/checkout@v6

# we explictly force Java 17 because that's the lowest one we support when building packages with ezbake
- name: Set up Java 17 for JRuby 9
if: runner.os == 'Linux' && contains(matrix.cfg.ruby, 'jruby-9')
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '17'
# JRuby 10.0.5 requires java 21 or 25
- name: Set up Java 21 for JRuby 10
if: runner.os == 'Linux' && contains(matrix.cfg.ruby, 'jruby-10')
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '21'
Comment on lines +61 to +74
Copy link
Copy Markdown
Member

@Sharpie Sharpie May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #463 added test coverage for JRuby 10.0 and 10.1, which obsoletes most of this PR. However, this setup to pin the Java version may still be relevant.

- name: Install ruby version ${{ matrix.cfg.ruby }}
uses: ruby/setup-ruby@v1
with:
Expand Down
1 change: 1 addition & 0 deletions spec/integration/util/rdoc/parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ module Puppet::Parser::Functions
<<-EOF
# The a_fact fact comment
Puppet.runtime[:facter].add("a_fact") do
setcode { 'a_fact_value' }
end
EOF
],
Expand Down
Loading