Skip to content

Add JRuby 10.0.5.0 and 10.1.0.0 to test matrix#463

Merged
silug merged 1 commit into
OpenVoxProject:mainfrom
silug:jruby-10
May 27, 2026
Merged

Add JRuby 10.0.5.0 and 10.1.0.0 to test matrix#463
silug merged 1 commit into
OpenVoxProject:mainfrom
silug:jruby-10

Conversation

@silug
Copy link
Copy Markdown
Contributor

@silug silug commented May 27, 2026

Short description

Adding JRuby 10 to the test matrix exposed RSpec failures:

  • JRuby 10's backtrace format reports module methods unqualified ('stack' instead of 'Puppet::Pops::PuppetStack.stack'), so the PUPPET_STACK_INSERTION_FRAME regex never matched and PuppetStack pseudo-frames stopped being interleaved into log backtraces. Broaden the regex to handle Ruby 3.3 (backtick), Ruby 3.4+ (qualified) and JRuby 10+ (unqualified) formats.
  • The integration specs for agent logging and the RDoc parser depend on the syslog and rdoc gems, which are restricted to platforms: [:ruby] in the Gemfile and so are absent on JRuby; skip those describes on JRuby, matching the existing idiom used elsewhere.
  • JRuby 10.1.0.0 raises ArgumentError('string contains null byte') instead of MRI's 'path name contains null byte' when a filename contains a NUL; accept either message in the affected json/yaml specs.

Fix generated by Claude.

Checklist

I have:

Adding JRuby 10 to the test matrix exposed RSpec failures:

* JRuby 10's backtrace format reports module methods unqualified
  ('stack' instead of 'Puppet::Pops::PuppetStack.stack'), so the
  PUPPET_STACK_INSERTION_FRAME regex never matched and PuppetStack
  pseudo-frames stopped being interleaved into log backtraces. Broaden
  the regex to handle Ruby 3.3 (backtick), Ruby 3.4+ (qualified) and
  JRuby 10+ (unqualified) formats.
* The integration specs for agent logging and the RDoc parser depend on
  the syslog and rdoc gems, which are restricted to platforms: [:ruby]
  in the Gemfile and so are absent on JRuby; skip those describes on
  JRuby, matching the existing idiom used elsewhere.
* JRuby 10.1.0.0 raises ArgumentError('string contains null byte')
  instead of MRI's 'path name contains null byte' when a filename
  contains a NUL; accept either message in the affected json/yaml
  specs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
@silug silug marked this pull request as ready for review May 27, 2026 17:28
@silug silug enabled auto-merge May 27, 2026 17:30
@silug silug merged commit f250a3f into OpenVoxProject:main May 27, 2026
17 checks passed
@silug silug deleted the jruby-10 branch May 27, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants