agent-runtime-main: remove more solaris/aix leftovers#177
Conversation
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Sharpie
left a comment
Sharpie
left a comment
There was a problem hiding this comment.
Looks good to me. Having builds across all the Linux-en report green is a good sign 👍
nmburgan
left a comment
nmburgan
left a comment
There was a problem hiding this comment.
Up to you if you want to also remove linux cross compiled blocks. If not, you've got a remove of requiring "runtime-#{settings[:runtime_project]}" in there that should be put back, but I think it's probably safe to remove linux cross compile support.
|
will tackle linux cross compilation in another PR |
|
|
||
| if platform.is_rpm? && !platform.is_aix? | ||
| if platform.is_rpm? | ||
| if platform.architecture =~ /aarch64|ppc64|ppc64le/ |
There was a problem hiding this comment.
Genuine question: should this also be:
| if platform.architecture =~ /aarch64|ppc64|ppc64le/ | |
| if platform.is_cross_compiled_linux? |
No idea if aarch64 is actually cross compiled or natively compiled
There was a problem hiding this comment.
good point. right now we use native ARM 64bit runners.
There was a problem hiding this comment.
Also when we were actually making ppc64le, we'd do it in an appropriate container using qemu emulation, so we truly don't do any cross compilation.
There was a problem hiding this comment.
@ekohl any chances that redhat would like to have powerpc packages, or could I remove ppc64 & ppc64le as well?
There was a problem hiding this comment.
I don't think we had a request for that so I'd be tempted to drop that. If you do it in a clean commit then it can be reverted in the future, right?
4 participants
Short description
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent