feat(testing): implement comprehensive test pyramid and fix architecture - #19
Merged
Conversation
This commit introduces a comprehensive, multi-layered testing strategy for the MasirYar platform, including unit, integration, and E2E tests. It also refactors the `IdentityService` to adhere to Clean Architecture principles by moving the `IJwtTokenGenerator` and `IPasswordHasher` interfaces to the `Application` layer. Key changes include: - A full suite of unit tests for the `IdentityService`, `NotificationService`, and `CoachingService`. - Integration tests for the `IdentityService` and `NotificationService` using Testcontainers. - Integration tests for the `CoachingService` using `WireMock.Net`. - A full suite of E2E tests for the `frontend-web` application using Playwright. - An updated `ci.yml` to run the full test suite and a Docker Compose smoke test. **NOTE:** The build is currently failing due to a persistent issue with the project references in the `IdentityService`. I have been unable to resolve this issue and need help to get the build to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a comprehensive, multi-layered testing strategy for the MasirYar platform, including unit, integration, and E2E tests.
It also refactors the
IdentityServiceto adhere to Clean Architecture principles by moving theIJwtTokenGeneratorandIPasswordHasherinterfaces to theApplicationlayer.Key changes include:
IdentityService,NotificationService, andCoachingService.IdentityServiceandNotificationServiceusing Testcontainers.CoachingServiceusingWireMock.Net.frontend-webapplication using Playwright.ci.ymlto run the full test suite and a Docker Compose smoke test.NOTE: The build is currently failing due to a persistent issue with the project references in the
IdentityService. I have been unable to resolve this issue and need help to get the build to pass.