Repository navigation
Home: its action comes from the button, not a key binding - #86
Merged
Merged
Conversation
labwc ran omarchy-home-button from an XF86HomePage binding, which matches only with no modifier held and only while labwc's input is in its normal mode; when it did not match, the press reached the system (omarchy-powerd logged it) and nothing happened. omarchy-powerd reads the button itself: Home let go after a press alone on a lit screen now starts omarchy-home-button in the session at once. A press that woke the screen or was half of Home + Power starts nothing, as before, and the script leaves a locked session alone. The script no longer asks omarchy-powerd about the press (no round trip, no verdict files), and labwc's binding only keeps the key from the focused app. A migration updates an existing ~/.config/labwc/rc.xml: with the old binding left, the script would run twice and read as a double press. Assisted-by: LLM
Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home sometimes did nothing: the press reached the system (omarchy-powerd logged it), but labwc's Home binding did not run, e.g. with any modifier held. Now omarchy-powerd, which reads the button itself, starts
omarchy-home-buttonwhen Home is let go after a press alone on a lit screen. Nothing between the button and the action can swallow it, and every press is logged.~/.config/labwc/rc.xml; with the old binding the script would run twice (a double press).Tested in the simulator (iPhone 7): locked press does nothing, single press opens and closes the launcher, Shift+Home opens the launcher, double press opens the overview and Home closes it, Home closes the control center (with the #84 script). Not yet on J71b.