Repository navigation
kernel: Report firmware-measured S8003 GPU time in debugfs - #156
Merged
Merged
Conversation
…ial pages On the iPad 5, vkCreateDevice() fails with VK_ERROR_INITIALIZATION_FAILED. CREATE_HWRT_DATASET returns -EINVAL without a log line when Mesa creates the dummy render target used during device creation. The A9 allocates the parameter manager's pages itself. Its free list is not grown by pvr_free_list_create(), so current_pages stays zero, but hwrt_init_kernel_structure() still checks it against the minimum. For chips with own_pm_pages, check initial_num_pages instead. This is the limit used to size the S8003 parameter manager's render blocks. Affects the Apple A9 (S8003). The A10 is unchanged. Assisted-by: LLM
…rejected
After a rejected command stream on the iPad 5, the next exec in another
process oopses in free_bprm with a bad rss-counter. slub_debug reports
"Object already free" on kmalloc-512: the object was allocated and freed
in pvr_fw_cmd_init(), then freed again from pvr_job_put().
When stream parsing fails, pvr_job_process_stream() frees the command.
The caller then releases the job, whose release path frees it again.
Clear the command pointer and length after freeing the rejected command.
Upstream has the same code. Affects every PowerVR device.
Fixes: eaf01ee5ba28 ("drm/imagination: Implement job submission and scheduling")
Assisted-by: LLM
Every geometry and fragment job on the iPad 5 is refused with -EINVAL, without a log line. The stream parser requires the A10's type-1 register extension on every Apple chip, while the A9 supplies its registers in extension type 2. Put each chip's required extension type and mask beside its stream definitions and obtain them through an Apple accessor. Keep the A10's values and leave compute without an Apple must-have entry. Affects the Apple A9 (S8003). The A10's validation values are unchanged. Assisted-by: LLM
…ry job Once rendering works on the iPad 5, every fragment job warns at WARN_ON(job->paired_job) in pvr_job.c, thousands of times a minute. Geometry jobs are never freed, and clients hang when destroying a render target: glmark2 and vkcube run until killed. Apple queues receive jobs linked by pvr_jobs_link_geom_frag(), but their free path does not drop the fragment job's paired geometry reference. That reference also keeps the geometry job's HWRT and context alive. Follow pvr_queue_free_job(): drop the paired geometry reference and clear paired_job before dropping the scheduler's reference. Affects the shared Apple queue used by the A9 (S8003) and A10 (T8010). The A10 has been build-tested only. Assisted-by: LLM
A client's first render on the iPad 5 fails without a log line when another client rendered last. Its geometry job returns -EBUSY, then its fragment job is refused with "fragment job without a geometry job". The call that takes a VM's PM sets is inside the dependency choice for consecutive jobs of the same VM. A new VM can therefore reach submission without a PM set when the previous fragment belonged to another VM. Call vm_scenes for every geometry job before selecting its dependency. Keep the existing prev_frag/last_frag choice and locking context. Affects the Apple A9 (S8003). The A10 has no vm_scenes callback and is unchanged. Assisted-by: LLM
The iPad 5's rejected geometry and fragment streams return -EINVAL without explaining which check failed. Applications fail to render, and the kernel gives no values with which to diagnose the rejection. Report malformed headers, invalid destination entries, short input, unsupported extensions and missing must-have bits at the rejecting check. Include the command type, entry or extension, and checked values. Use one rate-limited warning per rejected stream; callers log short reads so that propagated errors do not produce duplicate messages. Keep successful parsing and error returns unchanged. Affects every PowerVR device. Assisted-by: LLM
Render failures on the iPad 5 can leave a fragment job without its geometry job. S8003 submission errors otherwise return silently, so the kernel does not say which engine or stage failed. Add one rate-limited warning at each failing submission stage with the engine, error, VM and reason. Separate the PM pool build and record slot wait checks so that their errors can be distinguished. Keep submission and recovery behaviour unchanged. A fragment without its geometry scene is still refused. Affects the Apple A9 (S8003). The A10 is unchanged. Assisted-by: LLM
…e it loads The iPad 5 loses Firefox's WebGL context under multiple GPU clients. Firmware slot loads return -EIO, geometry jobs fail, and their fragment jobs are refused. Single-client runs do not hit the failure. VM map and unmap flushes take tag_lock but not submit_lock. They can bump a slot's host tag while DC_SLOT loads its root. With two or more bumps, firmware can copy an intermediate tag that matches neither the loaded tag nor the current host tag, falsely failing the load check. Mark each slot as loading under tag_lock while publishing its root and tag. Defer flushes on those slots, verify the exact loaded tag, then clear loading and apply any pending bump through the shared helper on both success and failure. submit_lock keeps the VM's job behind the pending bump, so firmware still invalidates stale translations before using the slot. Report the slot, loaded, firmware and current tags on a mismatch. Affects: Apple A9 (S8003). The A10 is unchanged. Assisted-by: LLM
…bugfs Host in-flight durations include queueing and firmware overhead, so they cannot show how long the GPU geometry and fragment phases actually ran. Read the retired phase-time u64 at W+0x550 or W+0x8ac before the record is cleared. Both submission paths wait for last_seq - 1 before writing the two-slot ring's next record, so its previous occupant has retired. Order that shared-memory read with dma_rmb(), preserve it across the fill, and account only successful fills before the result word is cleared. Expose accumulated geometry and fragment time, jobs and zero samples in apple_jobs, converting 24 MHz ticks by ticks * 125 / 3. Add only the small chip debugfs callback needed by that line; no timing parameters, phase-gap attribution or memory census. Submission ordering and power policy stay unchanged. Affects: Apple A9 (S8003), measurement only. The A10 is unchanged. Assisted-by: LLM
shaynelegault
pushed a commit
to shaynelegault/hardware
that referenced
this pull request
Nov 19, 2026
OrchardLinux#151, OrchardLinux#152, OrchardLinux#156 and OrchardLinux#157 each numbered their patches after OrchardLinux#150 as if they were the only follow-up. Number them in merge order: stability (0034-0042), firmware interrupt and PM (0043-0049), eviction (0050-0057), GPU time (0058), scene overlap (0059-0060). Assisted-by: LLM
shaynelegault
pushed a commit
to shaynelegault/hardware
that referenced
this pull request
Nov 19, 2026
OrchardLinux#151, OrchardLinux#152, OrchardLinux#153 and OrchardLinux#157 were each written on OrchardLinux#150 alone. Combined: - gpu/0051: the BO memory cap charges a native BO at creation, also when its pages come later. - gpu/0053: one record of the last two PM scenes, shared by the cache-line touch mask and the eviction veto. - gpu/0054: the restore path and VM_MAP size their page tables from the device address, as gpu/0042 made VM_MAP do. - gpu/0055: pools are prepared in the submit ioctl and sized for the firmware's feedback too; the job worker only switches to a prepared pool, between scenes, and never allocates. - gpu/0058: completions are signalled before the S8003 rings are touched, in the poll worker of gpu/0041 and gpu/0043. Two fixes on top: one submission order lock per device instead of one for every PowerVR device (gpu/0059), and the job worker allocates as before on chips that cannot evict (gpu/0060), so the A10 is unchanged. Left out: GPU time in debugfs (OrchardLinux#156; belongs in per-client fdinfo accounting) and the default-off scene overlap switch (OrchardLinux#157's second patch). The s8003 display DART patch becomes devices/s8000/0017; main took 0016 meanwhile. Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #150. Only the last commit is new in this PR.
Summary
Report accumulated geometry and fragment GPU phase time through the read-only
apple_jobs debugfs file. Harvest the firmware's u64 before clearing a reused
record, after its previous job has retired; order the read with dma_rmb().
Convert 24 MHz ticks with ticks * 125 / 3 and report jobs and zero samples.
Only the small read-only debugfs registration and chip callback needed by
the time line are included. It does not include phase-gap attribution,
memory census, PM instrumentation, scheduling changes or power-policy
changes. There is no behavior change.
Commits
Hardware
The iPad 5 development kernel uses these firmware-measured geometry and
fragment durations to separate GPU execution time from host in-flight
time. The two record slots alternate by sequence parity, and both submit
paths wait for the previous occupant to retire before reusing its record.
This PR makes no fps or busy-percentage claim.
Tested on Orchard main plus this series and our other pending patches (the J71t charging series and the rest of our iPad 5 development series), as one development kernel.
A10
Only the A9 was tested by us. The debugfs registration is shared; the time
line needs a chip callback. The S8003 one reads the phase time the S8003
firmware writes into its retired work record. The T8010 firmware uses a
different RTKit work-ring layout, and where (or whether) it reports phase
time is not mapped yet, so the T8010 gets no callback. The A9 offsets would
read an unrelated field there. The T8010 runs no new code.
A10 testers: nothing changes on the T8010. A report that the GPU still works
normally with this branch is enough.
How to test
sudo find /sys/kernel/debug/dri -name apple_jobs -exec cat {} + glmark2-es2-wayland --fullscreen sudo find /sys/kernel/debug/dri -name apple_jobs -exec cat {} +gpu_ns geometry <ns> fragment <ns> jobs <g> <f> zero <g> <f>growsbetween the two reads; fragment ns divided by fragment jobs is the
average GPU time per fragment job.
apple_jobsfile from this PR alone (nogpu_nsline even withthe other debugfs series applied). That is expected.
Testing
The stock apple-4k CI config has CONFIG_DRM_POWERVR_APPLE disabled; that
checks the disabled-backend stubs. The apple-16k build enables the Apple
backend and compiles both the S8003 and T8010 implementations.
The branch's CI config is unchanged and the effective config after olddefconfig
matches it byte for byte. Compiler debug output is disabled only for the
local build to fit the host. Reapplying the patch series can emit the
existing PMGR blank-line-at-EOF application warning under either config.
No new compiler warnings are accepted.