Repository navigation
kernel: Adopt the iPad 7 boot framebuffer in the A9/A10 display driver - #166
Conversation
The display pipe driver only accepted the 1536x2048 boot framebuffer of the 9.7-inch iPad 5 and 6, so on the iPad 7 (1620x2160, rows padded to 6528 bytes) it failed to probe and the display stayed on simpledrm. Take the size and stride from the boot simple-framebuffer and accept both known panels. Assisted-by: LLM
Build the display pipe's fixed mode from the boot simple-framebuffer's width and height instead of matching a table of two panels, so every A9/A10 board's panel is adopted, the iPad 7 being the first beyond the iPad 5/6. Only the physical size of the known panels stays in a table; an unknown panel reports its size as unknown instead of failing probe. Assisted-by: LLM
|
Thanks @jerricky26, merged. I generalized it on top: the driver now takes its mode from whatever boot framebuffer iBoot describes, so every A9/A10 board's panel is adopted, not just the two known sizes; only the panel's physical size still comes from a small table. Could you check on your iPad 7, with the next nightly (or a build of main), that the desktop is GPU-accelerated end to end? For example |
… switches Rework of OrchardLinux#170 on current main: - Renumber after main: drivers/drm 0010 (binding) and 0011 (driver), whose 0009 collided with OrchardLinux#166's; devices/s800x 0003. - drm/adbe: the transmitter's AUX channel is a struct drm_dp_aux with a transfer hook; DPCD access, retries, the capability and link status reads, the lane checks and DP_SET_POWER come from the shared DP helpers. The no-handshake TPS1/TPS2 sequence stays in the driver: it drives the transmitter's own training pattern register and the helpers have none. - Panel-off sleep is unconditional wherever the device tree gives the panel supply: the sleep_panel_off parameter, the adbe_panel debugfs file, the post-power-off witness read and the info-level logging are gone (gate reasons are dev_dbg). - The binding no longer forbids the panel supply on the A10 and allows the "dp" window there too; the T8010 device trees are unchanged until their supply line is known. - The driver selects DRM_DISPLAY_DP_HELPER (configs updated). Assisted-by: LLM
|
Tested on iPad 7 (J171), but on my local build (
|
Follow-up to #158. The display pipe driver only accepted the 1536x2048 boot framebuffer of the 9.7-inch iPad 5 and 6. On the iPad 7 (J171) the 10.2-inch panel runs at 1620x2160, with iBoot padding each row to 6528 bytes, so probe failed with
no 1536x2048 boot framebuffer(-EINVAL) and the display stayed on simpledrm. #158's verified DART scanout never ran there.The driver never programs timings, so it now takes the size and stride from the simple-framebuffer iBoot describes and accepts the two known panels, each with its own fixed mode and physical size. The adopted-plane check, park, plane limits and display DART verification use that size and stride. J71b/J72b behaviour is unchanged. J172 shares the 1620x2160 panel.
Tested on J171: adbe probes and replaces simpledrm, the display DART self-check passes and the panel scans out through the DART (
scanout through the display DART, boot framebuffer at 0xbb5e0000), the connector reports 1620x2160, and the desktop and touch work normally. Not tested on J172, J71b or J72b.