Skip to content

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Jan 12, 2026

Deployment

Deploy script 163_increase_oeth_redeem_fee

No new contracts deployed.

Governance

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.16%. Comparing base (17845ae) to head (15b5534).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2746      +/-   ##
==========================================
+ Coverage   39.40%   41.16%   +1.76%     
==========================================
  Files         126      126              
  Lines        5789     5789              
  Branches     1537     1537              
==========================================
+ Hits         2281     2383     +102     
+ Misses       3506     3404     -102     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shahthepro
shahthepro previously approved these changes Jan 12, 2026
sparrowDom
sparrowDom previously approved these changes Jan 12, 2026
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naddison36 naddison36 dismissed stale reviews from sparrowDom and shahthepro January 12, 2026 23:17

The merge-base changed after approval.

@naddison36 naddison36 merged commit 2e116ae into master Jan 13, 2026
14 of 17 checks passed
@naddison36 naddison36 deleted the nicka/deploy-163-redeem-fee branch January 13, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants