naming #2748
Open
naming #2748
+204
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
clement-ux,
naddison36 and
shahthepro
as code owners
shahthepro
reviewed
Jan 12, 2026
Collaborator
shahthepro
left a comment
shahthepro
left a comment
There was a problem hiding this comment.
We usually prefix a function parameter with underscore only if it has a conflict with a global variable. Any reason why this change is necessary?
Collaborator
I'm also not a fan of all parameters having leading underscores but it has been a practice for a lot of the contracts in the dollar repo |
Member
Author
|
I think we prefix all the local scope function variables. Checking 2 of the relatively recent strategy contracts to confirm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add underscore to variable names where applicable