Skip to content

Conversation

@sparrowDom
Copy link
Member

Add some address verification

* @param _operator Operator address
*/
function _setOperator(address _operator) internal {
require(_operator != address(0), "New Operator is address(0)");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote against this change. We need the ability to set the operator address to zero (as a way to disable it temporarily for any reason)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that setting the operator to 0 address would be analogous to pausing the strategy. As there wouldn't be any more message delivery between the 2 peer strategies. If that is a normal state we envision the strategy into being I am ok with allowing 0 address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants