Open
Conversation
- Add semaphore (3 concurrent) to limit parallel replication messages - Batch replication to groups of minAcks+2 with early exit when minimum reached - Wrap individual node messages in try/catch so one failing peer doesn't kill the whole operation - Add single retry on NACK before giving up on a peer - Increase publish message timeout from 15s to 60s for large knowledge assets Made-with: Cursor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the "Not replicated to enough nodes!" errors that happen when publishing large knowledge assets or during parallel publishes.
Changes
Why
Under load (parallel publishes with large assets), the node was sending all replication messages simultaneously. If any single peer failed or was slow, the whole publish would fail. This makes the replication process more resilient without changing the minimum replication requirements.
Made with Cursor