fix(dashboard): gate jobs/user admin ops and redact users in snapshot - #14
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(dashboard): gate jobs/user admin ops and redact users in snapshot#14cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Non-admin dashboard users could run kernel_exec jobs/cron and user list/create to read global automation instruction previews and enumerate all memory owners. kernel_snapshot also returned the full CLI user list via terminal_list_users without filtering. Reject jobs/cron/automation and user verbs for non-admin before IPC, skip the users IPC call for non-admin snapshots, and add regression tests. Co-authored-by: Yuxuan Liu <Osc-7@users.noreply.github.com>
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Multi-user dashboard deployments allowed any authenticated non-admin user to:
kernel_execverbsjobs/cron/automationand read global automation job instruction previews (may contain secrets).user list/user createto enumerate all memory owners or provision new owners.GET /api/kernel(kernel_snapshotcalledterminal_list_usersunfiltered).This is separate from PR #13 (tasks/queue/config), which remains open.
Root cause
Session-scoped access controls added in #4 did not cover global kernel console verbs or the
usersfield in kernel snapshots.Fix
jobs/cron/automation/userkernel_exec verbs for non-admin users before opening IPC.terminal_list_usersfor non-adminkernel_snapshotresponses (return empty list).tests/test_dashboard_auth.py.Validation
uv run pytest tests/test_dashboard_auth.py -v— 15 passed