fix(dashboard): align web session memory paths with chat history - #27
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(dashboard): align web session memory paths with chat history#27cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Dashboard chat passed metadata source=dashboard, routing writes to data/memory/dashboard/<user> while history reads from web/<user>. Also extend core owner resolve for web: session IDs switched via CLI. Co-authored-by: Yuxuan Liu <Osc-7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical data-path mismatch where Dashboard chat writes conversation memory to
data/memory/dashboard/<user>/while the UI reads history fromdata/memory/web/<user>/.Bug and impact
/chat/history.chat()/chat_stream()passedmetadata={"source": "dashboard"}, which overrode the IPC gateway'ssource=webviasetdefaultsemantics._daemon_chat_db_path()resolves history from theweb:session prefix./session switchtoweb:<user>left acquire owner ascli:rootbecause_resolve_core_ownerdid not includeweb:sessions.Fix
source=webin_with_client()so IPC and session IDs align._resolve_core_ownerto remapweb:sessions when callers pass CLI defaults.Validation
tests/test_core_owner_resolve.py(web session owner resolve)tests/test_kernel_runtime.py::test_dashboard_web_session_memory_owner_matches_history_path