fix(core_pool): release remote workspace when evict has no live core - #28
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(core_pool): release remote workspace when evict has no live core#28cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
After Core TTL eviction, delete_session and terminal_kill call evict(release_remote=True) but previously returned immediately when the session was not in _pool, leaving remote bindings and worker sessions active for deleted session IDs. Co-authored-by: Yuxuan Liu <liuyx2005@sjtu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After Core TTL eviction,
delete_sessionandterminal_killcallevict(session_id, release_remote=True)expecting remote worker bindings to be torn down.evict()returned immediately when the session was not in_pool, soworkspace_stateand the worker session stayed active.Trigger: User activates remote workspace → Core idles out (TTL) → user deletes the session → history/registry removed but remote binding persists → reused
session_idroutes bash/file to the old worker without/remote-use.Fix
When
evict()finds no live core butrelease_remote=True, callrelease_remote_workspace_session(None, ...)before returning.Tests
test_evict_release_remote_without_live_coreintests/test_kernel_runtime.pytest_evict_release_remote_closes_worker_workspacestill passes