Skip to content

Check Profile: offer fixes, including renumbering sticks to match this PC - #40

Merged
Osiris-DevWorks merged 1 commit into
release/0.11.0from
claude/project-thread-sjzrlr
Nov 20, 2026
Merged

Osiris-DevWorks merged 1 commit into
release/0.11.0from
claude/project-thread-sjzrlr

Conversation

@Osiris-DevWorks

Copy link
Copy Markdown
Owner

Requested by Amr · project thread

Why

While testing 0.11.0, Amr expected Check Profile to fix the problems it finds, not only list them. He chose to add the fixes before 0.11.0 ships.

What

Most findings now have a 🔧 link, and Fix all safe ones applies every fix that doesn't need a choice. Fixes are applied to the XML, written to a temp copy, and loaded as an unsaved, modified profile. The user reviews the changes and then uses Save Profile, which defaults to the original folder. The original file is never written.

Problem Fix In "Fix all safe ones"?
Profile js numbering ≠ this PC Renumber jsN everywhere so each binding follows its stick. Only offered when every profile stick is connected exactly once. yes, confirmed in the prompt
Forced "press" on a view action Back to game default yes
Tuning saved under an old device ID Move it to the stick's current ID, merging if that ID already has tuning yes
Bindings on inputs the stick lacks Clear them yes
One input switches several modes User picks which action keeps the input; the others are cleared no, asks
Hat lost its view actions Put the cleared view actions back on the free directions, guessed from the action names no, confirms
*_hold action forced to "press" Back to game default no (may be deliberate)

The renumber fix always runs last, so the other fixes still match the profile's old js numbers.

Verified

  • pytest tests/: 101 passed, including 11 new tests in tests/test_profile_fixer.py.
  • Amr's pre-repair live actionmaps.xml, with mock sticks set to a swapped order: after the fixes, only the two informational notes remain, and the fixed file parses with SCPE's parser.
  • Offscreen GUI run in mock mode (check_profile_swapped.json): Fix all safe ones renumbers the profile, and the device table goes all ✓. The choice fixes work, the profile is marked modified, Save is enabled, and the last-opened path still points at the original file.

Windows test

Add this to the #39 checklist: on the game PC, click Fix all safe ones on the live profile, then Save Profile to a new layout file and import that in game.


Generated by Claude Code

…s PC

Amr expected Check Profile to repair what it finds, not just list it
(2026-11-20), and chose to add fixes before 0.11.0 ships. Each finding now
carries a fix; profile_fixer applies them to the XML and writes a temp
copy, which the app loads as an unsaved, modified profile so the user
reviews and saves as usual. The original file is never written.

Safe fixes (applied by "Fix all safe ones"): drop forced "press" on view
actions, move tuning to the stick's current device ID, clear bindings on
inputs a stick lacks, and renumber jsN so every binding follows its stick
(only offered when each profile stick is connected exactly once).
Fixes that need a choice: which action keeps a button that switches
several modes, and restoring cleared view actions onto free hat
directions. Renumbering runs last so other fixes still match old jsN.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011hqxFh5GLh4UnV4rY8Fzdw
@Osiris-DevWorks Osiris-DevWorks self-assigned this Nov 20, 2026
@Osiris-DevWorks
Osiris-DevWorks merged commit 3f1a161 into release/0.11.0 Nov 20, 2026
1 check passed
@Osiris-DevWorks Osiris-DevWorks mentioned this pull request Nov 20, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants