Repository navigation
Don't crash on a channel folder Windows won't let us check (#595) - #596
Draft
Osiris-DevWorks wants to merge 1 commit into
Draft
Osiris-DevWorks wants to merge 1 commit into
Osiris-DevWorks wants to merge 1 commit into
Conversation
Open
A PTU folder linked to LIVE crashed the first launch after an update with WinError 448. Setup's "Launch Smart Citizen" ran the app as admin, and Windows won't let an elevated process follow a link a normal user made. Path.exists() lets that error through. - get_available_channels() treats a Data.p4k it can't check as missing. - The installer's launch entry runs as the original user. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hqxFfH6SHBcWCQMC5hLfC
Osiris-DevWorks
force-pushed
the
claude/project-thread-mpo7ig
branch
from
November 20, 2026 13:50
41d351a to
38f9be5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Amr · project thread
Fixes #595.
Problem
With PTU or HOTFIX linked to LIVE, the first launch after each update crashed with
OSError: [WinError 448] ... untrusted mount point: '...\PTU\Data.p4k'. The second launch worked.Setup runs as admin, and the "Launch Smart Citizen" checkbox at the end had no
runasoriginaluser, so that launch was elevated too. Windows won't let an elevated process follow a link a normal user made.Path.exists()only swallows a few Windows errors, so 448 got throughAppSettings.get_available_channels()and crashed the app. The in-app auto-update relaunch already usesExecAsOriginalUser, so only the manual installer path was hit.Changes
src/utils/settings.py: new_p4k_exists()catchesOSError, logs a warning and treats the channel as not installed.get_available_channels()uses it.installer.iss:runasoriginaluseron the[Run]launch entry, so the app never starts as admin from Setup.tests/test_channel_layout.py:test_unreadable_channel_counts_as_missing.No special handling for links. Normal installs behave the same as before.
Testing
test_channel_layout.pyandtest_sc_install_root.pyfail the same way with or without this change on Linux (they need Windows), so run them on Windows CI.Generated by Claude Code