Skip to content

Show generated stats and mission text in the selected language (#579) - #603

Merged
Osiris-DevWorks merged 3 commits into
release/3.1.0from
claude/project-thread-j441kl
Nov 20, 2026
Merged

Osiris-DevWorks merged 3 commits into
release/3.1.0from
claude/project-thread-j441kl

Conversation

@Osiris-DevWorks

@Osiris-DevWorks Osiris-DevWorks commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Requested by Amr · project thread

Closes #579.

What changes

  1. Generated text follows the selected language. The stat labels, mission details and journal lines the generator adds go through _t(), keyed by the English text. Each language has languages/<lang>/enhancements.json (same ht / at shape as ui.json). English output is byte for byte the same.
  2. All 11 languages have AI drafts of the 207 texts (at filled, ht empty), ready for the community to review.
  3. A table change regenerates. A translated language's .dataforge_stamp now carries its table's fingerprint, so an update that changes the table makes the set read as out of date. English stamps are unchanged.
  4. The community translation is re-downloaded at each start. Only for a URL source, as a conditional request. If a new file came down, the language's enhancements are marked stale and the app reloads, the same way a language switch does. Before this, only a language switch fetched it.

Left as they are on purpose

  • The four mission section headers and the Rep label. They are user settings, and owned_items.py finds the POTENTIAL BLUEPRINTS header by its text.
  • Tags such as [BP], item names (these come from the community translation), raw XML values, units and log lines.

Tests

  • New: tests/test_enhancement_text.py (the English list matches what the generator writes, every table has every key with its placeholders kept, translated runs, the stamp) and tests/test_language_translation_check.py (the start-time re-download).
  • tests/test_enhancements_stale_startup.py: its "current" stamp helper now writes what a translated run writes.
  • Full suite on Linux (with a winreg stub) before and after: no new failures. Windows CI (Tests + build verification) passed.

Manual test

  1. Pick German, Generate Enhancements, then check a ship weapon and a mission description in the table. The labels should be German.
  2. Switch back to English and generate again. The output should look the same as before this change.
  3. With German selected and a URL source, restart. The log should say it checked for a newer translation.

🤖 Generated with Claude Code

https://claude.ai/code/session_011hqxFgcUnWwdd1hCc8rBH1

The stat labels, mission details and journal lines the enhancement
generator adds now go through _t(), keyed by the English text, and each
language's languages/<lang>/enhancements.json holds its words (ht/at,
like ui.json). English output is unchanged. All 11 languages have AI
drafts of the 207 texts. A translated language's enhancements stamp
carries its table's fingerprint, so a table change regenerates.

Each start also fetches the selected language's community global.ini
again when its source is a URL (a conditional request), and reloads
with it when it changed, so a translation fixed after a game patch
arrives without switching language.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011hqxFgcUnWwdd1hCc8rBH1
@Osiris-DevWorks Osiris-DevWorks self-assigned this Nov 20, 2026
@Osiris-DevWorks Osiris-DevWorks mentioned this pull request Nov 20, 2026
@Osiris-DevWorks
Osiris-DevWorks marked this pull request as ready for review November 20, 2026 21:01
…art-citizen into claude/project-thread-j441kl

# Conflicts:
#	src/gui/CLAUDE.md
@claude

claude Bot commented Nov 20, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Doc conflicts only (CLAUDE.md, src/gui/CLAUDE.md, src/utils/CLAUDE.md),
both sides kept word for word.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011hqxFhCB4hwYZDdSQcaeNF
@Osiris-DevWorks
Osiris-DevWorks merged commit f5f9f38 into release/3.1.0 Nov 20, 2026
4 checks passed
Osiris-DevWorks pushed a commit that referenced this pull request Nov 20, 2026
…tab branch

Merges #598's branch, which holds the latest release/3.1.0, so this
runs CI on what release/3.1.0 will be once both are in. Doc conflicts
only (CLAUDE.md, src/gui, src/utils and tests CLAUDE.md), both sides
kept; the drawer still lists Order fourth and the Item Finder fifth.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011hqxFhCB4hwYZDdSQcaeNF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants