Repository navigation
Show generated stats and mission text in the selected language (#579) - #603
Merged
Merged
Conversation
The stat labels, mission details and journal lines the enhancement generator adds now go through _t(), keyed by the English text, and each language's languages/<lang>/enhancements.json holds its words (ht/at, like ui.json). English output is unchanged. All 11 languages have AI drafts of the 207 texts. A translated language's enhancements stamp carries its table's fingerprint, so a table change regenerates. Each start also fetches the selected language's community global.ini again when its source is a URL (a conditional request), and reloads with it when it changed, so a translation fixed after a game patch arrives without switching language. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hqxFgcUnWwdd1hCc8rBH1
…art-citizen into claude/project-thread-j441kl # Conflicts: # src/gui/CLAUDE.md
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Doc conflicts only (CLAUDE.md, src/gui/CLAUDE.md, src/utils/CLAUDE.md), both sides kept word for word. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hqxFhCB4hwYZDdSQcaeNF
Osiris-DevWorks
pushed a commit
that referenced
this pull request
Nov 20, 2026
…tab branch Merges #598's branch, which holds the latest release/3.1.0, so this runs CI on what release/3.1.0 will be once both are in. Doc conflicts only (CLAUDE.md, src/gui, src/utils and tests CLAUDE.md), both sides kept; the drawer still lists Order fourth and the Item Finder fifth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hqxFhCB4hwYZDdSQcaeNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Amr · project thread
Closes #579.
What changes
_t(), keyed by the English text. Each language haslanguages/<lang>/enhancements.json(sameht/atshape asui.json). English output is byte for byte the same.atfilled,htempty), ready for the community to review..dataforge_stampnow carries its table's fingerprint, so an update that changes the table makes the set read as out of date. English stamps are unchanged.Left as they are on purpose
owned_items.pyfinds the POTENTIAL BLUEPRINTS header by its text.[BP], item names (these come from the community translation), raw XML values, units and log lines.Tests
tests/test_enhancement_text.py(the English list matches what the generator writes, every table has every key with its placeholders kept, translated runs, the stamp) andtests/test_language_translation_check.py(the start-time re-download).tests/test_enhancements_stale_startup.py: its "current" stamp helper now writes what a translated run writes.winregstub) before and after: no new failures. Windows CI (Tests + build verification) passed.Manual test
🤖 Generated with Claude Code
https://claude.ai/code/session_011hqxFgcUnWwdd1hCc8rBH1