Repository navigation
Fix ISCC path detection in build_all.bat - #5
Merged
Merged
Conversation
The chained `if not defined ISCC_EXE if exist ...` pattern misparses when a candidate path contains parens — `C:\Program Files (x86)\Inno Setup 6\ ISCC.exe`'s `(x86)` collides with cmd's parenthesized-block lookahead and produces `\Inno was unexpected at this time.` before ISCC ever runs. Replaced with a FOR loop. Each %%P is one token to the surrounding parser, so the parens inside don't escape. Also simplified the not-found error message — the multi-line echo of paths-with-parens was the secondary trip hazard if that branch was ever reached. Validated the fix by running ISCC manually for the rebuild commit; this patch lets the next `build_all.bat` invocation detect Inno Setup at the user-scope `%LOCALAPPDATA%\Programs\Inno Setup 6\` install location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chained
if not defined X if exist Y set Zpattern in build_all.bat misparses when a candidate path contains(x86)— cmd's parenthesized-block lookahead trips on the inner parens and produces\Inno was unexpected at this time.before ISCC ever runs. Caused the v0.1.0 polish rebuild to fail at Step 5 even though PyInstaller had already succeeded.Fix
Replace the chain with a FOR loop. Each
%%Pis one token to the surrounding parser, so parens inside the path don't escape. Also simplified the not-found error message (it had a duplicate of the same parens-in-paths content that would have been the secondary trip hazard if that branch were ever reached).Validated by running ISCC manually for the rebuild; this patch lets the next
build_all.batinvocation detect Inno Setup at the user-scope%LOCALAPPDATA%\Programs\Inno Setup 6\install location without intervention.Test plan
scripts\build\build_all.batend-to-end on a clean working tree; verify Step 5 finds Inno Setup and producesdist\Super-TTS-0.1.0-Setup.exewithout the "\Inno was unexpected" error.