Skip to content

Fix ISCC path detection in build_all.bat - #5

Merged
Osiris-DevWorks merged 1 commit into
mainfrom
fix/build-iscc-path-detection
May 7, 2026
Merged

Osiris-DevWorks merged 1 commit into
mainfrom
fix/build-iscc-path-detection

Conversation

@Osiris-DevWorks

Copy link
Copy Markdown
Owner

Summary

The chained if not defined X if exist Y set Z pattern in build_all.bat misparses when a candidate path contains (x86) — cmd's parenthesized-block lookahead trips on the inner parens and produces \Inno was unexpected at this time. before ISCC ever runs. Caused the v0.1.0 polish rebuild to fail at Step 5 even though PyInstaller had already succeeded.

Fix

Replace the chain with a FOR loop. Each %%P is one token to the surrounding parser, so parens inside the path don't escape. Also simplified the not-found error message (it had a duplicate of the same parens-in-paths content that would have been the secondary trip hazard if that branch were ever reached).

Validated by running ISCC manually for the rebuild; this patch lets the next build_all.bat invocation detect Inno Setup at the user-scope %LOCALAPPDATA%\Programs\Inno Setup 6\ install location without intervention.

Test plan

  • Run scripts\build\build_all.bat end-to-end on a clean working tree; verify Step 5 finds Inno Setup and produces dist\Super-TTS-0.1.0-Setup.exe without the "\Inno was unexpected" error.

The chained `if not defined ISCC_EXE if exist ...` pattern misparses when
a candidate path contains parens — `C:\Program Files (x86)\Inno Setup 6\
ISCC.exe`'s `(x86)` collides with cmd's parenthesized-block lookahead and
produces `\Inno was unexpected at this time.` before ISCC ever runs.

Replaced with a FOR loop. Each %%P is one token to the surrounding
parser, so the parens inside don't escape. Also simplified the
not-found error message — the multi-line echo of paths-with-parens was
the secondary trip hazard if that branch was ever reached.

Validated the fix by running ISCC manually for the rebuild commit; this
patch lets the next `build_all.bat` invocation detect Inno Setup at the
user-scope `%LOCALAPPDATA%\Programs\Inno Setup 6\` install location.
@Osiris-DevWorks
Osiris-DevWorks merged commit c067476 into main May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant