Overhaul to support PK's JSON export #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactoring and updates (#1)
Major overhaul of program to better support PK's JSON export. Core functionality still present
OsricSystem
requested changes
Mar 5, 2021
Owner
OsricSystem
left a comment
OsricSystem
left a comment
There was a problem hiding this comment.
this looks more like the program is becoming an extension of PK, even tho this program is supposed to map systems, with an eventual future goal of being able to communicate with PK
here was the inspiration for the project so you can get a sense of what it was more supposed to be about https://twitter.com/TanyaTheBean/status/1365905241963520002?s=20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major overhaul of program to better support PK's JSON export. Core functionality still present