Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Secret customization #285

Open
koushyk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Secret customization #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c35104a
Added type and name to secret template
May 14, 2021
61d43e8
Update secret.yaml
koushyk May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/sonatype-nexus/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: Secret
metadata:
name: {{ template "nexus.name" . }}-secret
name: {{ toYaml .Values.secret.metadata.name }}
Copy link
Copy Markdown
Contributor

@rjkernick rjkernick May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need changed in the places that use the secret as well. I recommend adding something to the helpers.tpl and ensuring that all references that use the secret use the function you create in the helpers.tpl

namespace: {{ template "nexus.namespace" . }}
labels:
{{ include "nexus.labels" . | indent 4 }}
Expand All @@ -12,3 +12,4 @@ metadata:
data:
{{ toYaml .Values.secret.data | indent 2 }}
{{- end}}
type: {{ toYaml .Values.secret.type }}
3 changes: 3 additions & 0 deletions charts/sonatype-nexus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,12 @@ deployment:

# # To use an additional secret, set enable to true and add data
secret:
metadata:
name: nexus-secret
enabled: false
mountPath: /etc/secret-volume
readOnly: true
type: Opaque
data:

# # To use an additional service, set enable to true
Expand Down