fix(storage): correct page totals/slicing, remove-before-add on tree drag, no tombstone resurrection - #2336
Open
HandSonic wants to merge 2 commits into
Open
fix(storage): correct page totals/slicing, remove-before-add on tree drag, no tombstone resurrection#2336HandSonic wants to merge 2 commits into
HandSonic wants to merge 2 commits into
Conversation
…drag duplication, update tombstone, interrupt flag (code review follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verified review findings tracked in #2281: (1) consoleList reported the page-slice size as the total (wrong totals/hasNextPage) — now fetches all matches and slices; (2) operationLogList/taskList/listDataSources returned the full unsliced list as the page — now sliced with correct total; (3) tree drag-to-root duplicated the node (add without remove); (4) SmallDataStorage.update inserted records for unknown ids (tombstone resurrection) — now returns early, matching LargeDataStorage; (5) InterruptedException swallowed without restoring the interrupt flag. Regression tests + surefire user.home isolation added. Verified on fork HandSonic#21 (meaningful CI green) plus adversarial review.