[codex] fix(chat): preserve state after conversation rename - #2347
Draft
HanawaBanana wants to merge 1 commit into
Draft
[codex] fix(chat): preserve state after conversation rename#2347HanawaBanana wants to merge 1 commit into
HanawaBanana wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
chatListcurrentChatpage mapWhy
updateChatInforeplaced an element inside the existing Zustand array and then reused the same array reference. It also wrote{ id, title, ... }into thecurrentChatmap itself rather thancurrentChat[page]. After a successful rename, the persisted title could therefore remain stale in the active conversation, the page-map shape was polluted, and list-only selectors could miss the update.The page is captured before the request so a navigation while the rename is in flight cannot redirect the state update to a different page.
Impact
Conversation renames now appear immediately and consistently in both the conversation list and active header without mutating prior store state.
Closes #2346.
Validation
npm run test:chat-info-updatenpm run lint:eslintgit diff --check