Skip to content

fix(csslib): preserve group expressions and declaration flags in clones - #15

Merged
palmoni5 merged 3 commits into
mainfrom
palmoni5/csslib-declaration-group-clones-20261110
Nov 10, 2026
Merged

palmoni5 merged 3 commits into
mainfrom
palmoni5/csslib-declaration-group-clones-20261110

Conversation

@palmoni5

@palmoni5 palmoni5 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Problem

GroupTerm.clone() returned an empty group, losing its entire expression. Declaration.clone() did not propagate the legacy IE7 flag, so *zoom became zoom when cloned. VarDefinition.clone() reset the analyzer's badUsage state.

These clones are used by the analyzer when expanding @include of declaration mixins, so @mixin m { *zoom: 1; width: (2 5); } div { @include m; } compiled to zoom: 1; width: ();.

Fix

Deep-clone all literal terms in GroupTerm, preserve isIE7 in declaration clones and carry the variable's badUsage state. Public APIs and source spans are unchanged.

Tests

declaration_group_clone_test.dart covers group roundtrip with list independence, *zoom: 1 !important, variable invalid-usage state, and the end-to-end mixin include case. All four tests fail on main and pass with this change. Changelog entry added.

QA

dart format --output=none --set-exit-if-changed ., dart analyze --fatal-infos and dart test (186 passed, 1 skipped) are clean in pkgs/csslib.

Overlap: #16 rewrites Declaration.clone() and also adds ie7: isIE7; the textual conflict resolves to #16's version. CHANGELOG conflicts with the other csslib PRs of this round are list-order only.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

PR Health

Publish ✔️
Package Version Status Publish tag (post-merge)
package:csslib ⭐ 1.0.3-wip WIP (no publish necessary)
  • 16 already published.
  • 26 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
csslib Non-Breaking 1.0.2 1.0.3-wip 1.0.3-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
csslib Messages csslib/parser.dart::Analyzer::new::_messages
messages.dart::Messages::mergeMessages::newMessages
csslib/parser.dart::TopLevelIncludes::expand::messages
csslib/parser.dart::TopLevelIncludes::new::_messages
csslib/parser.dart::DeclarationIncludes::expand::messages
csslib/parser.dart::DeclarationIncludes::new::_messages
csslib/parser.dart::InheritExtends::new::_messages
csslib/parser.dart::PolyFill::new::_messages

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
csslib ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Coverage ✔️
File Coverage
pkgs/csslib/lib/src/tree.dart 💚 75 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@palmoni5
palmoni5 force-pushed the palmoni5/csslib-declaration-group-clones-20261110 branch from 1ecc365 to 7f4fae0 Compare November 10, 2026 20:03
@palmoni5
palmoni5 merged commit c03a905 into main Nov 10, 2026
17 checks passed
@palmoni5
palmoni5 deleted the palmoni5/csslib-declaration-group-clones-20261110 branch November 10, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant