Repository navigation
fix(csslib): serialize partial font styles without bogus family names - #19
Conversation
PR HealthPublish ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| csslib | Messages | csslib/parser.dart::Analyzer::new::_messages messages.dart::Messages::mergeMessages::newMessages csslib/parser.dart::TopLevelIncludes::expand::messages csslib/parser.dart::TopLevelIncludes::new::_messages csslib/parser.dart::DeclarationIncludes::expand::messages csslib/parser.dart::DeclarationIncludes::new::_messages csslib/parser.dart::InheritExtends::new::_messages csslib/parser.dart::PolyFill::new::_messages |
This check can be disabled by tagging the PR with skip-leaking-check.
Unused Dependencies ✔️
| Package | Status |
|---|---|
| csslib | ✔️ All dependencies utilized correctly. |
For details on how to fix these, see dependency_validator.
This check can be disabled by tagging the PR with skip-unused-dependencies-check.
License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/html/test/differential_test.dart |
| pkgs/html/test/dom_parsing_test.dart |
| pkgs/html/test/mxss_test.dart |
| pkgs/html/test/noah_ark_clause_limit_test.dart |
This check can be disabled by tagging the PR with skip-license-check.
Coverage ✔️
| File | Coverage |
|---|---|
| pkgs/csslib/lib/src/property.dart | 💚 51 % ⬆️ 4 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
25d9a3d to
a762493
Compare
Bugs
Font.cssExpressionproduced invalid CSS for partial fonts:_fontsAsStringconverted a nullfamilyto"null"and then stripped delimiters, producing a bogusulfamily name; empty lists left a trailing space.sizewas serialized asnullpx.16px/24), which CSS reads as a 24x multiplier; multiplier line heights were converted to pixels and could become/nullwithout a size.Fix
Serialize only the parts that are present (
weight,size[/line-height],family), joining family names directly. Pixel line heights keeppx; unitless (multiplier) line heights are written as-is.Regression tests
font_css_serialization_test.dart: missing/empty/multiple families, missing size, line height with/without font weight and without family, pixel vs. unitless line height. Two of the original tests fail onmain(16px ul, dropped line height); the rest guard existing output.QA
dart format --output=none --set-exit-if-changed .,dart analyze --fatal-infosanddart test(188 passed) inpkgs/csslib. Code merges cleanly with #14-#18; onlyCHANGELOG.mdconflicts (adjacent-wipentries).