Skip to content

fix(csslib): serialize partial font styles without bogus family names - #19

Merged
palmoni5 merged 8 commits into
mainfrom
palmoni5/csslib-font-css-serialization-20261110
Nov 10, 2026
Merged

palmoni5 merged 8 commits into
mainfrom
palmoni5/csslib-font-css-serialization-20261110

Conversation

@palmoni5

@palmoni5 palmoni5 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Bugs

Font.cssExpression produced invalid CSS for partial fonts:

  • _fontsAsString converted a null family to "null" and then stripped delimiters, producing a bogus ul family name; empty lists left a trailing space.
  • A null size was serialized as nullpx.
  • An explicit line height was silently dropped unless a font weight was set.
  • Pixel line heights were written without a unit (16px/24), which CSS reads as a 24x multiplier; multiplier line heights were converted to pixels and could become /null without a size.

Fix

Serialize only the parts that are present (weight, size[/line-height], family), joining family names directly. Pixel line heights keep px; unitless (multiplier) line heights are written as-is.

Regression tests

font_css_serialization_test.dart: missing/empty/multiple families, missing size, line height with/without font weight and without family, pixel vs. unitless line height. Two of the original tests fail on main (16px ul, dropped line height); the rest guard existing output.

QA

dart format --output=none --set-exit-if-changed ., dart analyze --fatal-infos and dart test (188 passed) in pkgs/csslib. Code merges cleanly with #14-#18; only CHANGELOG.md conflicts (adjacent -wip entries).

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

PR Health

Publish ✔️
Package Version Status Publish tag (post-merge)
package:csslib ⭐ 1.0.3-wip WIP (no publish necessary)
  • 16 already published.
  • 26 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
csslib Non-Breaking 1.0.2 1.0.3-wip 1.0.3-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
csslib Messages csslib/parser.dart::Analyzer::new::_messages
messages.dart::Messages::mergeMessages::newMessages
csslib/parser.dart::TopLevelIncludes::expand::messages
csslib/parser.dart::TopLevelIncludes::new::_messages
csslib/parser.dart::DeclarationIncludes::expand::messages
csslib/parser.dart::DeclarationIncludes::new::_messages
csslib/parser.dart::InheritExtends::new::_messages
csslib/parser.dart::PolyFill::new::_messages

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
csslib ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Coverage ✔️
File Coverage
pkgs/csslib/lib/src/property.dart 💚 51 % ⬆️ 4 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@palmoni5
palmoni5 force-pushed the palmoni5/csslib-font-css-serialization-20261110 branch from 25d9a3d to a762493 Compare November 10, 2026 19:58
@palmoni5
palmoni5 merged commit e5be26d into main Nov 10, 2026
17 checks passed
@palmoni5
palmoni5 deleted the palmoni5/csslib-font-css-serialization-20261110 branch November 10, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant