Skip to content

refactor(markdown): apply upstream review suggestions for footnotes and plain-text syntax - #42

Merged
palmoni5 merged 1 commit into
mainfrom
palmoni5/markdown-gemini-followup-20261111
Nov 11, 2026
Merged

palmoni5 merged 1 commit into
mainfrom
palmoni5/markdown-gemini-followup-20261111

Conversation

@palmoni5

Copy link
Copy Markdown
Member

Applies the gemini-code-assist suggestions accepted on the upstream PRs, so main stays equal to the union of the topic branches:

No behavior change. format / analyze --fatal-infos / test (2856 passed) clean locally.

@palmoni5 palmoni5 added the skip-changelog-check Skip the ecosystem changelog health check label Nov 11, 2026
@palmoni5
palmoni5 force-pushed the palmoni5/markdown-gemini-followup-20261111 branch from a5525d7 to 7854b90 Compare November 11, 2026 17:31
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

PR Health

Publish ✔️
Package Version Status Publish tag (post-merge)
package:markdown ⭐ 7.4.1-wip WIP (no publish necessary)
  • 16 already published.
  • 26 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
markdown Non-Breaking 7.3.1 7.4.1-wip 7.4.1-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
markdown ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Coverage ⚠️
File Coverage
pkgs/markdown/lib/src/document.dart 💔 96 % ⬇️ 0 %
pkgs/markdown/lib/src/inline_parser.dart 💚 99 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@palmoni5
palmoni5 merged commit a618692 into main Nov 11, 2026
17 checks passed
@palmoni5
palmoni5 deleted the palmoni5/markdown-gemini-followup-20261111 branch November 11, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:markdown skip-changelog-check Skip the ecosystem changelog health check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant