Skip to content

docs(csslib): describe partial Font.cssExpression output - #44

Merged
palmoni5 merged 1 commit into
mainfrom
palmoni5/font-css-doc-20261116
Nov 15, 2026
Merged

palmoni5 merged 1 commit into
mainfrom
palmoni5/font-css-doc-20261116

Conversation

@palmoni5

Copy link
Copy Markdown
Member

Replays the dart-lang#2847 review fix (topic branch csslib/font-css-serialization @7826b98a): the Font.cssExpression doc comment now says partial fonts print only the parts they have (e.g. 700), which isn't a complete font shorthand, and the CHANGELOG entry becomes one summary line.

csslib: dart format clean, dart analyze --fatal-infos clean, dart test +195 ~1.

Applies the dart-lang#2847 review: the cssExpression doc comment now
says partial fonts print only the parts they have, and the CHANGELOG entry
is one summary line.
@github-actions

Copy link
Copy Markdown

PR Health

Publish ✔️
Package Version Status Publish tag (post-merge)
package:csslib ⭐ 1.0.3-wip WIP (no publish necessary)
  • 16 already published.
  • 26 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
csslib Non-Breaking 1.0.2 1.0.3-wip 1.0.3-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
csslib Messages csslib/parser.dart::Analyzer::new::_messages
messages.dart::Messages::mergeMessages::newMessages
csslib/parser.dart::TopLevelIncludes::expand::messages
csslib/parser.dart::TopLevelIncludes::new::_messages
csslib/parser.dart::DeclarationIncludes::expand::messages
csslib/parser.dart::DeclarationIncludes::new::_messages
csslib/parser.dart::InheritExtends::new::_messages
csslib/parser.dart::PolyFill::new::_messages

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
csslib ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Coverage ✔️
File Coverage
pkgs/csslib/lib/src/property.dart 💚 49 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@palmoni5
palmoni5 merged commit f9bf372 into main Nov 15, 2026
17 checks passed
@palmoni5
palmoni5 deleted the palmoni5/font-css-doc-20261116 branch November 15, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant