Skip to content

ci(csslib): add mandatory format, analyze and VM test verification - #9

Closed
palmoni5 wants to merge 2 commits into
mainfrom
palmoni5/csslib-ci-hard-fail-20261110
Closed

palmoni5 wants to merge 2 commits into
mainfrom
palmoni5/csslib-ci-hard-fail-20261110

Conversation

@palmoni5

Copy link
Copy Markdown
Member

Motivation

The monorepo's generic Health / coverage check can report success even when a newly added Dart test fails to load. This happened on csslib PR #2 with an unresolved PageDirective type; the Health check stayed green despite a Dart compilation error in its logs.

Scope

  • Add an explicit CI job that runs dart pub get, dart format --set-exit-if-changed, dart analyze --fatal-infos and dart test --platform vm in pkgs/csslib, failing the job on any command error.
  • Cover Ubuntu and Windows on the stable Dart SDK.
  • Trigger on PRs modifying the package, manual dispatch, and the verification branch for bootstrap testing.
  • Keep existing upstream csslib and Health jobs unchanged; no dependency pin in Otzaria.

QA

This is an independent verification gate, not a replacement for regression tests. Check the Actions run on this PR before marking ready. Existing csslib workflow may require enabling in the fork's Actions settings.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

PR Health

Publish ✔️
  • 16 already published.
  • 27 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

This check can be disabled by tagging the PR with skip-publish-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check (for example, for non-user-visible changes when the package version is already at -wip).

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
None No packages found to check.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@palmoni5
palmoni5 marked this pull request as ready for review November 10, 2026 09:01
@palmoni5

Copy link
Copy Markdown
Member Author

Closing in favor of re-enabling the existing upstream package:csslib workflow (.github/workflows/csslib.yaml) in this fork's Actions settings: it runs the same format/analyze/VM-test gate, and additionally covers the package's minimum SDK (3.1) and Dart dev, so the fork keeps zero CI diff from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant