feat: move compilation into component chunk code#17
Open
Myriad-Dreamin wants to merge 2 commits intoOverflowCat:masterfrom
Open
feat: move compilation into component chunk code#17Myriad-Dreamin wants to merge 2 commits intoOverflowCat:masterfrom
Myriad-Dreamin wants to merge 2 commits intoOverflowCat:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
93a75f7 to
e16be49
Compare
9d1860a to
f213f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we run
renderToHTMLishwhen transforming the module, this makes it hard to use methods onNodeTypstDocuments. I don't want to do too many things in this PR so I only move compilation into component chunk code and test that we can invokedoc.body()inside of the callback ofcreateComponent.new feature, a
bodyprop to only render<body/>of html output: