Skip to content

Use proper normals resolution #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateuszstompor merged 1 commit into from
Jan 3, 2026
Merged

Use proper normals resolution #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Engine/Core/Extensions/Metal/MTLPixelFormat+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ extension MTLPixelFormat {
.rgba16Float
}
static var gBufferNMC: MTLPixelFormat {
.rgba16Float
.rgba32Float
}
static var gBufferPRC: MTLPixelFormat {
.rgba32Float
Expand Down
6 changes: 3 additions & 3 deletions Engine/Shaders/DeferredRendering/GBuffer.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct RasterizerData {

struct GBufferData {
half4 albedoRoughness [[color(0)]];
half4 normalMetallic [[color(1)]];
float4 normalMetallic [[color(1)]];
float4 positionReflectance [[color(2)]];
half2 velocity [[color(3)]];
};
Expand Down Expand Up @@ -94,7 +94,7 @@ fragment GBufferData fragmentGBuffer(RasterizerData in [[stage_in]],
// should be possible to configure it
float3 normalEncoded = material.normals.sample(textureSampler, in.uv).xyz;
float3 normalDecoded = normalEncoded * 2 - 1;
half3 normalWorldSpace = half3(TBN * normalDecoded);
float3 normalWorldSpace = float3(TBN * normalDecoded);
half3 color = material.albedo.sample(textureSampler, in.uv).rgb;
half2 current = half2(in.currentClipSpacePosition.xy / in.currentClipSpacePosition.w);
half2 previous = half2(in.previousClipSpacePosition.xy / in.previousClipSpacePosition.w);
Expand All @@ -104,7 +104,7 @@ fragment GBufferData fragmentGBuffer(RasterizerData in [[stage_in]],

return {
half4(color, roughness),
half4(normalWorldSpace, metallic),
float4(normalWorldSpace, metallic),
float4(in.cameraSpacePosition, 0.04),
velocity
};
Expand Down
Loading