Repository navigation
The page contract, and what this repo's page test does not assert - #16
Merged
Merged
Conversation
Three reviews over the twelve `CLAUDE.md`, the thirteen READMEs and the index record. * The tooling section told a reader to prefer an MCP server over Grep and to fall back only when the graph does not cover the question. That server is declared in this repository's `.mcp.json`, so it is absent whenever the session starts one directory up, and neither index has a hook. Rewritten to say both. * `sitegen/` listed three modules of seven. The four missing include `numbers.py`, which exists because one figure once shipped as `14,745` and `14 745` from two call sites, and `theme.py`, which is the file the page-spec work touches. * The page contract governs eleven surfaces and was stated in none of the twelve files. Stated here - including that `tests/test_site_committed.py` is **not** its local carrier: it asserts byte-equality with the generator and the import budget, and no clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reviews over the twelve
CLAUDE.md, the thirteen READMEs and the index record.when the graph does not cover the question. That server is declared in this repository's
.mcp.json, so it is absent whenever the session starts one directory up, and neitherindex has a hook. Rewritten to say both.
sitegen/listed three modules of seven. The four missing includenumbers.py, whichexists because one figure once shipped as
14,745and14 745from two call sites, andtheme.py, which is the file the page-spec work touches.Stated here - including that
tests/test_site_committed.pyis not its local carrier:it asserts byte-equality with the generator and the import budget, and no clause.