Repository navigation
The portfolio code leaves the eyebrow and the footer - #20
Merged
Merged
Conversation
A recruiter cannot decode "P2", and this page published it twice -- once in the eyebrow, which is the first line a reader meets, and once in the footer. The eyebrow loses the whole label because "Portfolio" without its code is not a phrase; the footer keeps "Portfolio project" because it is one and because it tells a reader the page belongs to a set. Generator and page move in the same commit. test_site_committed.py byte-diffs them, so editing either alone reddens it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recruiter cannot decode
P2, and this page published it twice — once in the eyebrow, the first line a reader meets, and once in the footer.docs/index.html:146<p class="eyebrow">Portfolio P2 · applied statistics · no A/B library underneath</p><p class="eyebrow">applied statistics · no A/B library underneath</p>docs/index.html:439<p>Portfolio project P2 · <a…>source on GitHub</a><p>Portfolio project · <a…>source on GitHub</a>sitegen/page.py:328,:292The two are treated differently on purpose. The eyebrow loses the whole label, because
Portfoliowithout its code is not a phrase — it is half of one. The footer keepsPortfolio project, because that is a phrase and it tells a reader the page belongs to a set rather than standing alone.Generator and page move in one commit:
tests/test_site_committed.pybyte-diffs them, so editing either alone reddens it.The eyebrow keeps its element — the portfolio index checker's clause 4 gates the eyebrow's presence, and only its text is free. That checker reads
clear, 1 undecidedfor this surface, unchanged.Part of stage S8a, wave W1 —
ADR-0007in the portfolio index. Twelve sibling pull requests; the index re-points afterwards in one commit.