Add no_std support and introduce feature std.#22
Merged
0ndorio merged 3 commits intoP3KI:masterfrom Jul 11, 2019
Merged
Conversation
Delet0r
approved these changes
Jul 9, 2019
thequux
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
no_stdsupport and a new default feature calledstd. It also replacesskepticas documentation testing dependency with the far more light weightdoc_comment.This has currently two known problems:
During the
doctestbuild step the following error message appears. It seems like this based on andoctestinternal problem and has now further consequences as even after the message is printed all tests run properly (related: No global memory allocator error when testing no_std crate that does link to std rust-lang/rust#54010, liballoc doc tests are "silently" failing rust-lang/rust#52243).As soon as
doc_commentis used with the#[cfg(test)]attribute it is not working as expected and won't run the doc tests. I assume that the reason here is rustdoc not using the test flag (Revert "Set test flag when rustdoc is running with --test option" rust-lang/rust#61199). So this will not work until Stabilize cfg(doc) rust-lang/rust#61351 and rustdoc: set cfg(doctest) when collecting doctests rust-lang/rust#62213 are merged and we change it into#[cfg(doctest)].