build(afm): install bacon explicitly from source#51
Merged
Conversation
bacon ships no prebuilt binaries (crates.io-source-only), so it previously resolved only via cargo-binstall's implicit `compile` fallback — the last link in binstall 1.19.x's default strategy chain (`crate-meta-data,quick-install,compile`). Make the source install explicit with `cargo install --locked bacon` so the bacon layer no longer depends on binstall's default strategies: a future default change, or adopting aozora's fail-fast `--strategies` policy on the batch, would otherwise silently break it. No behaviour change today — binstall already compiled it. Mirrors aozora #55. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
cargo binstall --no-confirm --locked --root /usr/local baconwithcargo install --locked baconin thecargo-toolsDocker stage (own layer, comment updated with the rationale).Why
baconships no prebuilt binaries — it is crates.io-source-only. The old line "worked" only via cargo-binstall's implicitcompilefallback, the last link in binstall 1.19.x's default strategy chain. Verified in-image:afm never passes
--strategies, so binstall silently compiled bacon from source. Making the source install explicit removes that hidden dependency on binstall's defaults: a future default-strategy change — or adopting aozora's fail-fast--strategies crate-meta-data,quick-installpolicy on the batch — would otherwise break the bacon layer with no warning. Mirrors aozora #55.No behaviour change today — binstall already compiled bacon; this just makes it deliberate and visible.
Verification (local, Docker)
docker compose build dev→ exit 0; log showsCompiling bacon v3.23.0→Installed package bacon v3.23.0(source build, not a prebuilt fetch).docker compose run --rm dev bacon --version→bacon 3.23.0(on PATH via the existingCOPY --from=cargo-tools /usr/local/cargo/bin/).just ci(19 steps) +just prop-deepgreen.🤖 Generated with Claude Code