ci: fix commitlint dependabot guard#97
Merged
Merged
Conversation
The guard skipped committed only when github.actor was dependabot, but a human re-trigger (`gh pr update-branch` on a dependabot PR) changes the actor — so committed ran and failed on the bot's long subjects and on the update-branch merge commit. Guard on the PR author instead, and pass `--no-merge-commit` so merge commits never fail the lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependabot commitlint skip (added in #94) guarded on
github.actor, whichis the triggering identity — a human
gh pr update-branchon a dependabotPR flips it away from
dependabot[bot], socommittedran and failed on thebot's long subjects and on the update-branch merge commit. This wedged #70/#71/#96.
github.event.pull_request.user.login), stableacross re-triggers.
committed --no-merge-commitsogh pr update-branchmerge commits("Merge branch 'main' …") never fail the lint.
Unblocks the open dependabot PRs (#70/#71/#96). Part of P4suta/aozora#105.