absorption cross section adjustment [WIP]#25
Open
STIK98 wants to merge 4 commits intoPAHdb:masterfrom
Open
Conversation
Made the cross section calculation similar to that of López-Puertas et al. 2013
adjusted the original code from the nasa ames pahdb database and fixed two small errors such as correct references to Draine & Li 2007 and Li & Draine 2001. implemented the nc>40 requirement for the cutoff frequency, and replaced the charge !=0 with the updated 2008 code.
STIK98
changed the title
Author
|
I forgot to incorporate this comment: #23 (comment). So right now this PR is still a WIP. |
Owner
|
Hi Florence, Unfortunately, the CI failed. You will need to update the unit tests as well, as the new cross-sections will result in slightly different temperatures and intensities. The old code yielded Breaking things up into smaller, feature-specific pull-requests make total sense. I'm glad you aren't discouraged yet by the often finicky nature of CI. You can close your other pull-request if you're going forward with smaller ones like this. I noted your WIP. Good luck, take care, and best wishes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last time I made a pull request for multiple features, after some coding courses and an excellent IT wizard, I decided to tackle one feature at a time. This is the adjustment of the cross-section calculation, with hopefully the necessary workflow checks and commands running locally before pushing to GitHub. Hopefully, everything works now! If not, I would love to hear it!