Merge V2. Major update #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move code into object-oriented structure, whilst keeeping loadPamguardBinaryFile, loadPamguardBinaryFolder and loadPamguardMultiFile the same. - Add a testing suite to compare the new v2 code with the 'legacy' v1 code.
Check namespaces in several functions that had not been tested, checked was using latest version of several database functions and added some slightly better help comments at the top of some functions.
Fix type on function
Update to be able to search efficiently in noise / background data files
Fix reading of annotations from binary files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update with revised folder structure, class structures, and use of namespaces.