-
Notifications
You must be signed in to change notification settings - Fork 2
[mod/#155] Mypage 뷰 개선 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
sonms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 고생많으셨습니다!
궁금한 점이 있어 여기에 남깁니다!
-
가끔 onClick이랑 onValueChanged 가 빠진 부분이 있는데 필요하지 않아서 구현하지 않고 {}만 남기신 건지 아니면 추후 API 붙이실 때 반영하실 예정인지 궁금합니다!
-
파라미터로 전달되는 변수들 역시 state로 묶어서 관리할 수 있을 것 같은데 나중에 확인 부탁드려용
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/CourseInfoScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/component/CourseRouteItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/component/CourseRouteItem.kt
Show resolved
Hide resolved
...c/main/java/com/paw/key/presentation/ui/mypage/courseinfo/navigation/CourseInfoNavigation.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/main/component/PetCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileListScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileListScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/userinfo/component/UserProfileItem.kt
Outdated
Show resolved
Hide resolved
| @Composable | ||
| fun UserGenderButton( | ||
| user: String, | ||
| isSelect: Boolean, | ||
| onClick: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Box( | ||
| contentAlignment = Alignment.Center, | ||
| modifier = modifier | ||
| .clip(RoundedCornerShape(8.dp)) | ||
| .background( | ||
| color = if (isSelect) { | ||
| PawKeyTheme.colors.primary | ||
| } else { | ||
| PawKeyTheme.colors.background | ||
| } | ||
| ) | ||
| .border( | ||
| width = 1.dp, | ||
| color = if (isSelect) { | ||
| Color.Transparent | ||
| } else { | ||
| PawKeyTheme.colors.defaultMiddle | ||
| }, | ||
| shape = RoundedCornerShape(8.dp) | ||
| ) | ||
| .noRippleClickable(onClick) | ||
| .padding(horizontal = 68.dp, vertical = 16.dp) | ||
| ) { | ||
| Text( | ||
| text = user, | ||
| color = if (isSelect) { | ||
| PawKeyTheme.colors.background | ||
| } else { | ||
| PawKeyTheme.colors.defaultMiddle | ||
| }, | ||
| style = if (isSelect) { | ||
| PawKeyTheme.typography.bodyActive | ||
| } else { | ||
| PawKeyTheme.typography.bodyDefault | ||
| }, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val backgroundColor = if (isSelect) PawKeyTheme.colors.primary else PawKeyTheme.colors.background
val borderColor = if (isSelect) Color.Transparent else PawKeyTheme.colors.defaultMiddle
val contentColor = if (isSelect) PawKeyTheme.colors.background else PawKeyTheme.colors.defaultMiddle
val textStyle = if (isSelect) PawKeyTheme.typography.bodyActive else PawKeyTheme.typography.bodyDefault
Box(
contentAlignment = Alignment.Center,
modifier = modifier
.clip(shape)
.background(color = backgroundColor)
.border(
width = 1.dp,
color = borderColor,
shape = shape
)
.noRippleClickable(onClick)
.padding(horizontal = 68.dp, vertical = 16.dp)
) {
Text(
text = user,
color = contentColor,
style = textStyle
)
}이거도 묶으면 좋을 것 같은데 어떻게 생각하시나ㅓ요?
지금도 사실 보기에 나쁘지는 않아요
ISSUE
❗ WORK DESCRIPTION
📢 TO REVIEWERS
📸 SCREENSHOT
-.Clipchamp.10.mp4