Remove the StartupBar promo bar - #272
Merged
Merged
Conversation
The startupbar.co listing brings no traffic, so the loader script goes away entirely instead of just being switched off: - delete components/common/startup-bar.tsx and its render in the locale layout - drop STARTUPBAR_ENABLED and the envKillSwitch helper (only user) from lib/config/features.ts, plus the .env.example entry - revert the suppressHydrationWarning workarounds on the sticky header and the park background that only existed because the loader mutated the DOM before hydration - update docs/development/flags-and-debug.md accordingly Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YaGdkbuvyj6UsqjFwgmPgN
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startupbar.co listing hasn't brought anything, so the bar goes away for good instead of just being flipped off via
NEXT_PUBLIC_STARTUPBAR.What this unwinds:
components/common/startup-bar.tsxis deleted, along with its render inapp/[locale]/layout.tsx.STARTUPBAR_ENABLEDis gone fromlib/config/features.ts, together with theenvKillSwitchhelper that existed only for it, and the matching.env.exampleentry.suppressHydrationWarningon the sticky header and onParkBackgroundis reverted — both were only there because the vendor loader shiftedtop: 0elements before React hydrated. With the loader gone, hydration mismatches on those elements should surface again instead of being silenced.docs/development/flags-and-debug.mdno longer documents the flag or the kill-switch pattern.The two dated documents under
docs/superpowers/still mention the loader; they describe the state of the code at the time they were written, so they stay as they are.Checked locally:
tsc --noEmit, ESLint, Prettier and a fullpnpm buildall pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01YaGdkbuvyj6UsqjFwgmPgN
Generated by Claude Code