Remove the typewriter effect from the hero search placeholder - #273
Merged
Conversation
The homepage search field showed park and ride names typed letter by letter into its placeholder. The field now shows the translated static placeholder from the first paint. Gone with it: the useTypewriter state machine and TypewriterPlaceholder leaf in hero-search-input.tsx, the typewriter-blink keyframes in globals.css, and the placeholderShown property on hero_search_clicked, which without the typewriter would have billed an extra Umami event per click just to say "default". useActiveOnScreen stays for the countdowns and charts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AhKNXtQGeTthk4hSmbJxY1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage search field typed park and ride names into its placeholder on a loop. That effect is gone: the field shows the translated static placeholder from the first paint, on the homepage and the howto pages alike (they share
HeroSearchInput).Removed along with it:
useTypewriterstate machine, its reducer and theTypewriterPlaceholderleaf incomponents/search/hero-search-input.tsx– the component is now a thin wrapper aroundSearchCommandtypewriter-blinkkeyframes inapp/globals.cssplaceholderShownproperty onhero_search_clicked(lib/analytics/umami.ts). It only ever reported which phrase was on screen; without the typewriter it would have billed an extra Umami event per click just to say "default".useActiveOnScreenstays untouched apart from its doc comment – the countdowns, flip clock and weather charts still pause through it.tsc --noEmitand ESLint are clean.Generated by Claude Code