fix: manifest no longer claims the server is strictly read-only - #18
Merged
Conversation
The MCPB manifest still claimed the server is strictly read-only, but pcm_update_save (and soon pcm_update_cyclist_ratings) write new .cdb files. Describe the actual write model instead: the source save is never modified and existing files are never overwritten. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the MCPB package manifest copy to reflect that the server now supports write/edit tools (while still preserving the safety guarantee that the original .cdb save is never modified or overwritten).
Changes:
- Update
descriptionto state the server supports querying and editing. - Update
long_descriptionto document the write model: edits are serialized to a new.cdband existing files are not overwritten.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCPB manifest (
manifest.json) still described the server as "strictly read-only", but that has been outdated sincepcm_update_savelanded (#15): the server now ships write tools. This is the description users see when installing the.mcpbpackage, so it was misleading.descriptionandlong_descriptionto say the server queries and edits PCM databases..cdbfile — the source save is never modified and existing files are never overwritten.Found during a full MCP-server review (mcp-builder skill).