Skip to content

fix: unify country field to human-readable name across cyclist tools #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpicciolli merged 2 commits into from
Jul 5, 2026
Merged

fix: unify country field to human-readable name across cyclist tools #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348346c
fix: unify country field to human-readable name across cyclist tools
mpicciolli Jul 5, 2026
73b7e73
fix: enforce consistent use of human-readable country names across tools
mpicciolli Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ All tools are prefixed with `pcm_` and carry `readOnlyHint: true` / `destructive
- **Platform:** auto-discovery is Windows-only. On macOS/Linux (Wine/Proton),
`pcm_list_saves`/`getPcmRoot` throw — pass an absolute `.cdb` path to `pcm_select_save`.
- **Logging** must go to `stderr` (`console.error`); stdout is the MCP transport.
- **Country fields** must use `STA_country.gene_sz_flag` (human-readable name, e.g.
`France`), never `STA_country.CONSTANT` (internal constant). Keep this consistent
across all tools that expose a cyclist/team country.

## README maintenance

Expand Down
4 changes: 2 additions & 2 deletions src/tools/get-team-roster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const cyclistSchema = z.object({
country: z
.string()
.nullable()
.describe("Country name (STA_country.CONSTANT)"),
.describe("Country name (STA_country.gene_sz_flag), e.g. `France`"),
age: z
.number()
.nullable()
Expand Down Expand Up @@ -138,7 +138,7 @@ export function registerGetTeamRoster(server: McpServer): void {
tr.CONSTANT AS type,
ct.iYearEnd AS contractEndYear,
ct.finan_i_period_wage AS wage,
co.CONSTANT AS country,
co.gene_sz_flag AS country,
${ratingsColumns(hasMediumMountain)}
FROM DYN_cyclist c
LEFT JOIN STA_type_rider tr ON c.fkIDtype_rider = tr.IDtype_rider
Expand Down
4 changes: 2 additions & 2 deletions src/tools/search-cyclist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const cyclistSchema = z.object({
country: z
.string()
.nullable()
.describe("Country name (STA_country.CONSTANT)"),
.describe("Country name (STA_country.gene_sz_flag), e.g. `France`"),
...ratingsSchema.shape,
currentAbility: z
.number()
Expand Down Expand Up @@ -70,7 +70,7 @@ export function registerSearchCyclist(server: McpServer): void {
c.gene_sz_lastname,
${ratingsColumns(hasMediumMountain)},
${hasCurrentAbility ? "c.value_f_current_ability" : "NULL"} AS currentAbility,
co.CONSTANT AS country
co.gene_sz_flag AS country
FROM DYN_cyclist c
LEFT JOIN STA_region r ON c.fkIDregion = r.IDregion
LEFT JOIN STA_country co ON r.fkIDcountry = co.IDcountry
Expand Down
Loading
Loading