fix: correct tool names in error messages and rename pcm_select_save to pcm_validate_save - #21
Merged
Merged
Conversation
Error messages and a doc comment in saves.ts referred to the tool as select_save, but the registered tool name is pcm_select_save. Agents follow these messages to pick the next tool, so use the exact name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR corrects user-facing guidance in src/saves.ts so error messages and the getPcmRoot doc comment reference the actual registered tool name pcm_select_save (instead of the outdated select_save), which is important for agent-driven tool selection.
Changes:
- Updated
getPcmRootdoc comment to mentionpcm_select_save. - Updated non-Windows platform error message in
getPcmRootto instruct usingpcm_select_save. - Updated “no PCM data found” error message in
listSavesto instruct usingpcm_select_save.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The tool is a stateless validator — it stores nothing and returns the save's metadata — but "select" implied a stateful session selection. Rename the tool, its register function and source file, and update the README/AGENTS docs and error messages accordingly. BREAKING CHANGE: clients calling pcm_select_save must switch to pcm_validate_save. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mpicciolli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/saves.ts(unsupported platform ingetPcmRoot, missing PCM data inlistSaves) told the caller to useselect_save, but tool names carry thepcm_prefix. Agents follow these messages to pick the next tool, so the exact name matters.pcm_select_savetopcm_validate_save: the tool is a stateless validator (it stores nothing and returns the save's metadata), and "select" wrongly implied a stateful session selection. The register function, source file, README, AGENTS.md and error messages were updated accordingly.Breaking change: clients calling
pcm_select_savemust switch topcm_validate_save.