fix: use full pcm_validate_save tool name in error messages - #22
Merged
Conversation
Error messages and a doc comment in saves.ts referred to the tool as select_save, but the registered tool name is pcm_select_save. Agents follow these messages to pick the next tool, so use the exact name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The tool is a stateless validator — it stores nothing and returns the save's metadata — but "select" implied a stateful session selection. Rename the tool, its register function and source file, and update the README/AGENTS docs and error messages accordingly. BREAKING CHANGE: clients calling pcm_select_save must switch to pcm_validate_save. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Column padding in AGENTS.md and README.md wasn't adjusted when pcm_select_save was renamed to pcm_validate_save, leaving the table rows misaligned.
There was a problem hiding this comment.
Pull request overview
This PR renames the save-path validation tool from pcm_select_save to pcm_validate_save, updates user-facing error messages to reference the full tool name, and refreshes related documentation to match the new name.
Changes:
- Rename the registered tool name and registration function to
pcm_validate_save/registerValidateSave. - Update error/help text in
src/saves.tsto referencepcm_validate_saverather thanselect_save. - Update README/AGENTS documentation references and table entries to the new tool name.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/validate-save.ts | Renames the registered tool name and title to pcm_validate_save. |
| src/tools/index.ts | Updates tool registration wiring to call registerValidateSave. |
| src/saves.ts | Updates comments and thrown error messages to reference pcm_validate_save. |
| README.md | Updates documentation references and the tools table/usage flow to pcm_validate_save. |
| AGENTS.md | Updates tool list references to pcm_validate_save (but still needs follow-up corrections per comments). |
Comments suppressed due to low confidence (1)
src/tools/validate-save.ts:19
- Renaming the tool from
pcm_select_savetopcm_validate_saveis a breaking change for any existing clients calling the old tool name. If backward compatibility matters, consider keepingpcm_select_saveregistered as a deprecated alias that forwards to the same implementation for at least one release cycle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-name-in-error-messages
…-name-in-error-messages
…gs and save tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcm_select_savetopcm_validate_savefor clarity (the tool validates a path, it doesn't select anything stateful).